[all-commits] [llvm/llvm-project] 10eb32: [lldb] Improve 'lang objc tagged-pointer info' com...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Fri Nov 5 13:19:14 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 10eb32f45d40e180a229590f57dd0a61f97f1bc9
      https://github.com/llvm/llvm-project/commit/10eb32f45d40e180a229590f57dd0a61f97f1bc9
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-11-05 (Fri, 05 Nov 2021)

  Changed paths:
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
    M lldb/test/API/lang/objc/tagged-pointer/TestTaggedPointerCmd.py
    M lldb/test/API/lang/objc/tagged-pointer/main.m

  Log Message:
  -----------
  [lldb] Improve 'lang objc tagged-pointer info' command

Don't try to get a class descriptor for a pointer that doesn't look like
a tagged pointer. Also print addresses as fixed-width hex and update the
test.


  Commit: 6d48e2505c7a68a470e75b61ad504d51db0f8a36
      https://github.com/llvm/llvm-project/commit/6d48e2505c7a68a470e75b61ad504d51db0f8a36
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-11-05 (Fri, 05 Nov 2021)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

  Log Message:
  -----------
  [lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient

>From the documentation:

  A Twine is not intended for use directly and should not be stored, its
  implementation relies on the ability to store pointers to temporary
  stack objects which may be deallocated at the end of a statement.
  Twines should only be used accepted as const references in arguments,
  when an API wishes to accept possibly-concatenated strings.

rdar://84799118

Differential revision: https://reviews.llvm.org/D113314


Compare: https://github.com/llvm/llvm-project/compare/c92a253cf0dd...6d48e2505c7a


More information about the All-commits mailing list