[all-commits] [llvm/llvm-project] 3151fc: [NFC] Fix typo in comment for `isReplicationMask()`

Roman Lebedev via All-commits all-commits at lists.llvm.org
Fri Nov 5 09:23:22 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3151fca9f3698a1dc4f07a26351f5c6f06688d89
      https://github.com/llvm/llvm-project/commit/3151fca9f3698a1dc4f07a26351f5c6f06688d89
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-11-05 (Fri, 05 Nov 2021)

  Changed paths:
    M llvm/include/llvm/IR/Instructions.h

  Log Message:
  -----------
  [NFC] Fix typo in comment for `isReplicationMask()`

This was mentioned in https://reviews.llvm.org/D113214#inline-1080385
but i forgot to stage the change before committing.


  Commit: 0b36431810076790b1f3362495b2eaebc9be96c7
      https://github.com/llvm/llvm-project/commit/0b36431810076790b1f3362495b2eaebc9be96c7
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-11-05 (Fri, 05 Nov 2021)

  Changed paths:
    M llvm/unittests/IR/InstructionsTest.cpp

  Log Message:
  -----------
  [NFCI] InstructionTest: trim `InstructionsTest.ShuffleMaskIsReplicationMask_*` complexity

These tests have pretty high O() complexity due to their nature,
which leads to potentially-long runtimes.

While in release build for me they took ~1 and ~2 sec,
as noted in https://reviews.llvm.org/D113214#inline-1080479
they take minutes in debug build.

Fine-tune the amount of permutations they deal with,
without affecting the test coverage. After this,
they take <~10ms each for me (in release build),
hopefully that is good-enough for debug build too.


Compare: https://github.com/llvm/llvm-project/compare/2c4ba3e9d36e...0b3643181007


More information about the All-commits mailing list