[all-commits] [llvm/llvm-project] 795ff7: [libcxxabi] Fix NO_THREADS version of test_excepti...

DanielMcIntosh-IBM via All-commits all-commits at lists.llvm.org
Thu Nov 4 16:30:33 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 795ff77840e161018a44fe30ae53ad05e5d98f97
      https://github.com/llvm/llvm-project/commit/795ff77840e161018a44fe30ae53ad05e5d98f97
  Author: Daniel McIntosh <Daniel.McIntosh at ibm.com>
  Date:   2021-11-04 (Thu, 04 Nov 2021)

  Changed paths:
    M libcxxabi/test/test_exception_storage.pass.cpp

  Log Message:
  -----------
  [libcxxabi] Fix NO_THREADS version of test_exception_storage.pass.cpp

`thread_code` returns param, which for NO_THREADS is going to be
`&thread_globals`. Thus, the return value will never be null. The test
was probably meant to check if `*thread_code(&thread_globals) == 0`.
However, to avoid the extra cast, and to bring the NO_THREADS version
more in line with the regular version of the test, this changes it to
check if thread_globals == 0 directly.

Reviewed By: ldionne, #libc_abi

Differential Revision: https://reviews.llvm.org/D113048




More information about the All-commits mailing list