[all-commits] [llvm/llvm-project] 8129b0: [mlir][ods] Op::verify should not call OpAdaptor::...

Jeff Niu via All-commits all-commits at lists.llvm.org
Thu Nov 4 12:13:08 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8129b04b8a9e4ca65c25d1e837a3c72cbcebf4c9
      https://github.com/llvm/llvm-project/commit/8129b04b8a9e4ca65c25d1e837a3c72cbcebf4c9
  Author: Mogball <jeffniu22 at gmail.com>
  Date:   2021-11-04 (Thu, 04 Nov 2021)

  Changed paths:
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/test/mlir-tblgen/predicate.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir][ods] Op::verify should not call OpAdaptor::verify

OpAdaptor::verify performs string lookups on an attribute dictionary. By
calling OpAdaptor::verify, Op::verify is not able to use cached attribute
identifiers for faster lookups.

Reviewed By: jpienaar, rriddle

Differential Revision: https://reviews.llvm.org/D113039




More information about the All-commits mailing list