[all-commits] [llvm/llvm-project] cbd215: [LIT] Add win32 PLATFORM env var to test config

Muhammad Omair Javaid via All-commits all-commits at lists.llvm.org
Thu Nov 4 05:44:16 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cbd215dfe51df47e020c676a32c2672c573641a8
      https://github.com/llvm/llvm-project/commit/cbd215dfe51df47e020c676a32c2672c573641a8
  Author: Muhammad Omair Javaid <omair.javaid at linaro.org>
  Date:   2021-11-04 (Thu, 04 Nov 2021)

  Changed paths:
    M lldb/test/Shell/helper/build.py
    M llvm/utils/lit/lit/llvm/config.py

  Log Message:
  -----------
  [LIT] Add win32 PLATFORM env var to test config

LIT skips various system environment variables while building test
config. It turns out that we require PLATFORM environment variable for
detection of x86 vs Arm windows platform.

This patch adds system environment variable PLATFORM into LIT test
config for detection of win32 Arm platform.

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D113165


  Commit: b595137fe1c06c6fd72ad3c5b30a7750eeca07c1
      https://github.com/llvm/llvm-project/commit/b595137fe1c06c6fd72ad3c5b30a7750eeca07c1
  Author: Muhammad Omair Javaid <omair.javaid at linaro.org>
  Date:   2021-11-04 (Thu, 04 Nov 2021)

  Changed paths:
    M lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp
    M lldb/source/Plugins/Process/Windows/Common/arm64/RegisterContextWindows_arm64.cpp

  Log Message:
  -----------
  [LLDB] Fix Cpsr size for WoA64 target

CPSR on Arm64 is 4 bytes in size but windows on Arm implementation is trying to read/write 8 bytes against a byte register causing LLDB unit tests failures.

Ref: https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-arm64_nt_context

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D112471


Compare: https://github.com/llvm/llvm-project/compare/b4992dbb21ff...b595137fe1c0


More information about the All-commits mailing list