[all-commits] [llvm/llvm-project] 753eba: Revert "[AArch64][SVE][InstCombine] Combine contig...

Peter Waller via All-commits all-commits at lists.llvm.org
Wed Nov 3 06:45:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 753eba64213ef20195644994df53d564f30eb65f
      https://github.com/llvm/llvm-project/commit/753eba64213ef20195644994df53d564f30eb65f
  Author: Peter Waller <peter.waller at arm.com>
  Date:   2021-11-03 (Wed, 03 Nov 2021)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
    R llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-gatherscatter.ll

  Log Message:
  -----------
  Revert "[AArch64][SVE][InstCombine] Combine contiguous gather/scatter to load/store"

This reverts commit 1febf42f03f664ec84aedf0ece3b29f92b10dce9, which has
a use-of-uninitialized-memory bug.

See: https://reviews.llvm.org/D112076


  Commit: 7a34145f407e4ec652111f5e9483a36f816a6a3a
      https://github.com/llvm/llvm-project/commit/7a34145f407e4ec652111f5e9483a36f816a6a3a
  Author: Peter Waller <peter.waller at arm.com>
  Date:   2021-11-03 (Wed, 03 Nov 2021)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
    A llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-gatherscatter.ll

  Log Message:
  -----------
  Reland "[AArch64][SVE][InstCombine] Combine contiguous gather/scatter to load/store"

This reverts commit 753eba64213ef20195644994df53d564f30eb65f.

Contiguous gather => masked load:

  (sve.ld1.gather.index Mask BasePtr (sve.index IndexBase 1))
  => (masked.load (gep BasePtr IndexBase) Align Mask undef)

Contiguous scatter => masked store:

  (sve.ld1.scatter.index Value Mask BasePtr (sve.index IndexBase 1))
  => (masked.store Value (gep BasePtr IndexBase) Align Mask)

Tests with <vscale x 2 x double>:

[Gather, Scatter] for each [Positive test (index=1), Negative test
(index=2), Alignment propagation].

Differential Revision: https://reviews.llvm.org/D112076


Compare: https://github.com/llvm/llvm-project/compare/5fbcf677347e...7a34145f407e


More information about the All-commits mailing list