[all-commits] [llvm/llvm-project] 6c5a89: [mlir][nvvm] NFC: Fix unused template arg tablegen...

Cullen Rhodes via All-commits all-commits at lists.llvm.org
Wed Nov 3 05:09:57 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c5a897c447b5294e557ce3f22b08e5cb333c443
      https://github.com/llvm/llvm-project/commit/6c5a897c447b5294e557ce3f22b08e5cb333c443
  Author: Cullen Rhodes <cullen.rhodes at arm.com>
  Date:   2021-11-03 (Wed, 03 Nov 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

  Log Message:
  -----------
  [mlir][nvvm] NFC: Fix unused template arg tablegen warning

Identified in D109359.


  Commit: d968b173d33be1a5819e9f5f9a8b4258775a65ed
      https://github.com/llvm/llvm-project/commit/d968b173d33be1a5819e9f5f9a8b4258775a65ed
  Author: Cullen Rhodes <cullen.rhodes at arm.com>
  Date:   2021-11-03 (Wed, 03 Nov 2021)

  Changed paths:
    M llvm/cmake/modules/TableGen.cmake
    M llvm/include/llvm/TableGen/Record.h
    M llvm/lib/TableGen/Main.cpp
    M llvm/lib/TableGen/Record.cpp
    M llvm/lib/TableGen/TGParser.cpp
    M llvm/lib/TableGen/TGParser.h
    M llvm/test/TableGen/2010-03-24-PrematureDefaults.td
    M llvm/test/TableGen/TemplateArgRename.td
    M llvm/test/TableGen/cond-subclass.td
    M llvm/test/TableGen/defmclass.td
    M llvm/test/TableGen/if.td
    M llvm/test/TableGen/isa.td
    M llvm/test/TableGen/pr8330.td
    A llvm/test/TableGen/warn-unused-template-arg.td

  Log Message:
  -----------
  [TableGen] Emit a warning for unused template args

Add a warning to TableGen for unused template arguments in classes and
multiclasses, for example:

  multiclass Foo<int x> {
    def bar;
  }

  $ llvm-tblgen foo.td

  foo.td:1:20: warning: unused template argument: Foo::x
  multiclass Foo<int x> {
                     ^
A flag '--no-warn-on-unused-template-args' is added to disable the
warning. The warning is disabled for LLVM and sub-projects if
'LLVM_ENABLE_WARNINGS=OFF'.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D109359


Compare: https://github.com/llvm/llvm-project/compare/1cb13fddb9d8...d968b173d33b


More information about the All-commits mailing list