[all-commits] [llvm/llvm-project] 8f1019: [X86][VARARG] Assign MMO earlier to avoid prolog i...

Phoebe Wang via All-commits all-commits at lists.llvm.org
Tue Nov 2 19:13:49 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f101971b6d54e2fc470e853e413fd01cfff20b5
      https://github.com/llvm/llvm-project/commit/8f101971b6d54e2fc470e853e413fd01cfff20b5
  Author: Phoebe Wang <pengfei.wang at intel.com>
  Date:   2021-11-03 (Wed, 03 Nov 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ExpandPseudo.cpp
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h
    M llvm/lib/Target/X86/X86InstrCompiler.td
    M llvm/lib/Target/X86/X86InstrInfo.td
    M llvm/test/CodeGen/X86/vaargs-prolog-insert.ll

  Log Message:
  -----------
  [X86][VARARG] Assign MMO earlier to avoid prolog insert point been sunk across VASTART_SAVE_XMM_REGS

The changes in D80163 defered the assignment of MachineMemOperand (MMO)
until the X86ExpandPseudo pass. This will result in crash due to prolog
insert point been sunk across the pseudo instruction VASTART_SAVE_XMM_REGS.

Moving the assignment to the creation of the node can avoid the problem.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D112859




More information about the All-commits mailing list