[all-commits] [llvm/llvm-project] 264d3b: [MachO] Use error instead of fatal for missing -arch

[Shoaib Meenai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 264d3b6d4e08401c5b50a85bd76e80b3461d77e6
      https://github.com/llvm/llvm-project/commit/264d3b6d4e08401c5b50a85bd76e80b3461d77e6
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2021-10-31 (Sun, 31 Oct 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/test/MachO/color-diagnostics.test
    M lld/test/MachO/driver.test
    M lld/test/MachO/search-paths-darwin.test

  Log Message:
  -----------
  [MachO] Use error instead of fatal for missing -arch

`fatal` should only be used for malformed inputs according to
ErrorHandler.h; `error` is more appropriate for missing arguments,
accompanied by a check to bail out early in case of the error. Some
tests need to be adjusted accordingly.

Makes `lld/test/MachO/arch.s` pass with `LLD_IN_TEST=2`.

Reviewed By: #lld-macho, int3

Differential Revision: https://reviews.llvm.org/D112879