[all-commits] [llvm/llvm-project] 025f54: [OpenMP][DeviceRTL] Fixed an issue that causes han...

Shilei Tian via All-commits all-commits at lists.llvm.org
Sat Oct 30 11:44:42 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 025f5492401489269ab980910f4fda98f5b06bd1
      https://github.com/llvm/llvm-project/commit/025f5492401489269ab980910f4fda98f5b06bd1
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-10-30 (Sat, 30 Oct 2021)

  Changed paths:
    M openmp/libomptarget/DeviceRTL/src/Parallelism.cpp

  Log Message:
  -----------
  [OpenMP][DeviceRTL] Fixed an issue that causes hang in SU3

The synchronization at the end of parallel region cannot make sure all threads
exit the scope. As a result, the assertions right after it might be hit, and
further the `state::assumeInitialState(IsSPMD)` in `__kmpc_target_deinit` may
not hold as well. We either add a synchronization right after the parallel region,
or remove the assertions and assuptions. Here we choose the first one as those
assertions and assumptions can help optimizations.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D112861




More information about the All-commits mailing list