[all-commits] [llvm/llvm-project] 1b7589: [IR] Merge createReplacementInstr into ConstantExp...

[Jay Foad via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b758925adf6d78c89c70d2673689695e90fa993
      https://github.com/llvm/llvm-project/commit/1b758925adf6d78c89c70d2673689695e90fa993
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2021-10-29 (Fri, 29 Oct 2021)

  Changed paths:
    M clang/lib/CodeGen/CGCUDANV.cpp
    M llvm/include/llvm/IR/Constants.h
    M llvm/lib/IR/Constants.cpp
    M llvm/lib/IR/ReplaceConstant.cpp
    M llvm/lib/Target/XCore/XCoreLowerThreadLocal.cpp
    M llvm/lib/Transforms/IPO/GlobalOpt.cpp
    M llvm/lib/Transforms/Scalar/ConstantHoisting.cpp

  Log Message:
  -----------
  [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

createReplacementInstr was a trivial wrapper around
ConstantExpr::getAsInstruction, which also inserted the new instruction
into a basic block. Implement this directly in getAsInstruction by
adding an InsertBefore parameter and change all callers to use it. NFC.

A follow-up patch will remove createReplacementInstr.

Differential Revision: https://reviews.llvm.org/D112791


  Commit: 56f03d25b42ac539c046e157e99ad824d0239dd0
      https://github.com/llvm/llvm-project/commit/56f03d25b42ac539c046e157e99ad824d0239dd0
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2021-10-29 (Fri, 29 Oct 2021)

  Changed paths:
    M llvm/include/llvm/IR/ReplaceConstant.h
    M llvm/lib/IR/ReplaceConstant.cpp

  Log Message:
  -----------
  [IR] Remove createReplacementInstr. NFC.

It is unused since D112791.

Differential Revision: https://reviews.llvm.org/D112795


Compare: https://github.com/llvm/llvm-project/compare/21a1d4cf719e...56f03d25b42a