[all-commits] [llvm/llvm-project] 947e14: [mlir][sparse] move conversion test back to origin...
Aart Bik via All-commits
all-commits at lists.llvm.org
Thu Oct 28 09:03:54 PDT 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 947e14be98796b5e680cc7bcae262d4256c8e05c
https://github.com/llvm/llvm-project/commit/947e14be98796b5e680cc7bcae262d4256c8e05c
Author: Aart Bik <ajcbik at google.com>
Date: 2021-10-28 (Thu, 28 Oct 2021)
Changed paths:
M mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conversion.mlir
Log Message:
-----------
[mlir][sparse] move conversion test back to original CHECK testing
Rationale:
The silent exit(1) gives little clues on where the error occurs on failure
and may even be confusing at first. The CHECK testing of all computed values
and indices may be a little bit more elaborate, but it directly pinpoints
where errors happen if they occur. This style is also consistent with
the other tests, which I actually prefer.
Reviewed By: bixia
Differential Revision: https://reviews.llvm.org/D112688
More information about the All-commits
mailing list