[all-commits] [llvm/llvm-project] 734f91: [Attributor][NFC] Improve debug messages

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Wed Oct 27 19:04:58 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 734f91441d539f19a263a44d00e8b74c3f9d3d0c
      https://github.com/llvm/llvm-project/commit/734f91441d539f19a263a44d00e8b74c3f9d3d0c
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    M llvm/lib/Transforms/IPO/Attributor.cpp

  Log Message:
  -----------
  [Attributor][NFC] Improve debug messages


  Commit: 172078729fced990126cb9c0dc4fe19650069703
      https://github.com/llvm/llvm-project/commit/172078729fced990126cb9c0dc4fe19650069703
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    A llvm/test/Transforms/Attributor/openmp_parallel.ll

  Log Message:
  -----------
  [Attributor][NFX] Pre-commit test case exposing a problem

The test case is the IR of:

```
  void func(float * restrict a, float *b, int N) {
    N = 199;
    #pragma omp parallel for
    for (int i = 1; i < N; i++)
      a[i] = b[i] + 1.0;
  }
```


  Commit: acf3093117e354c7cdf097600cd406a16720804d
      https://github.com/llvm/llvm-project/commit/acf3093117e354c7cdf097600cd406a16720804d
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    M llvm/lib/Transforms/IPO/AttributorAttributes.cpp
    M llvm/test/Transforms/Attributor/openmp_parallel.ll

  Log Message:
  -----------
  [Attributor][FIX] Do not ignore memory writes in AAMemoryBehavior

Even if we look for `nocapture` we need to bail on escaping pointers.
The crucial thing is that we might not look at a big enough scope when
we derive the memory behavior. Thus, it might be `nocapture` in a larger
context while it is "captured" in a smaller context.


  Commit: 6cf6fa6ef1c28de0d553a38defa719342774f104
      https://github.com/llvm/llvm-project/commit/6cf6fa6ef1c28de0d553a38defa719342774f104
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    M clang/lib/Sema/SemaOpenMP.cpp
    A clang/test/AST/ast-dump-openmp-begin-declare-variant_template_4.cpp

  Log Message:
  -----------
  [OpenMP] Declare variants for templates need to match # template args

A declare variant template is only compatible with a base when the
number of template arguments is equal, otherwise our instantiations will
produce nonsensical results.

Exposes as part of D109344.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D109770


Compare: https://github.com/llvm/llvm-project/compare/22acda48ff32...6cf6fa6ef1c2


More information about the All-commits mailing list