[all-commits] [llvm/llvm-project] 7f3693: [lld/mac] Don't crash on undefined symbols with --...

Nico Weber via All-commits all-commits at lists.llvm.org
Wed Oct 27 13:26:04 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f369304dfe9e3a62db0244b3427319d33bec4df
      https://github.com/llvm/llvm-project/commit/7f369304dfe9e3a62db0244b3427319d33bec4df
  Author: Nico Weber <thakis at chromium.org>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    M lld/MachO/ICF.cpp
    M lld/test/MachO/invalid/undefined-symbol.s

  Log Message:
  -----------
  [lld/mac] Don't crash on undefined symbols with --icf=all

ICF runs before relocation processing, but undefined symbol errors
are only emitted during relocation processing.

So just ignore Undefineds during ICF (instead of crashing) -- lld
will emit an error once ICF is done.

Fixes PR52330.

Differential Revision: https://reviews.llvm.org/D112643




More information about the All-commits mailing list