[all-commits] [llvm/llvm-project] c80604: tsan: remove real func check from interceptors

Dmitry Vyukov via All-commits all-commits at lists.llvm.org
Tue Oct 26 23:47:40 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c80604f7a30a5eee5421a4d9786ef135b03c25a8
      https://github.com/llvm/llvm-project/commit/c80604f7a30a5eee5421a4d9786ef135b03c25a8
  Author: Dmitry Vyukov <dvyukov at google.com>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    M compiler-rt/lib/tsan/rtl/tsan_interceptors.h

  Log Message:
  -----------
  tsan: remove real func check from interceptors

If the real function is not intercepted,
we are going to crash one way or another.
The question is just in the failure mode:
error message vs NULL deref. But the message
costs us a check in every interceptor and
they are not observed to be failing in real life
for a long time, also other sanitizers don't
have this check as well (also crash on
NULL deref if that happens).
Remove the check from non-debug mode.

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D112540




More information about the All-commits mailing list