[all-commits] [llvm/llvm-project] 2fa224: [mlir] Placeholder used in predicate should be the...

ChiaHungDuan via All-commits all-commits at lists.llvm.org
Tue Oct 26 10:37:33 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fa22488d5d11e2b3f7cefc3bd19f73c27fc6dac
      https://github.com/llvm/llvm-project/commit/2fa22488d5d11e2b3f7cefc3bd19f73c27fc6dac
  Author: Chia-hung Duan <chiahungduan at google.com>
  Date:   2021-10-26 (Tue, 26 Oct 2021)

  Changed paths:
    M mlir/include/mlir/IR/OpBase.td

  Log Message:
  -----------
  [mlir] Placeholder used in predicate should be the base type

Added a notification in the placeholder section. While writing things
like preciate of an attribute, we may embed certain placeholder in the C
expression. Note that the type of the placeholder is only guaranteed to
be the base type like mlir::Type, it's better not to use the derived
type which is based on the implementation.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D112396




More information about the All-commits mailing list