[all-commits] [llvm/llvm-project] 622150: [lld-macho] Put GOT into `__DATA` segment where ap...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 622150ad5f21149ae010188a06707d07b4d3865b
      https://github.com/llvm/llvm-project/commit/622150ad5f21149ae010188a06707d07b4d3865b
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-10-26 (Tue, 26 Oct 2021)

  Changed paths:
    M lld/MachO/SyntheticSections.cpp
    M lld/test/MachO/builtin-rename.s

  Log Message:
  -----------
  [lld-macho] Put GOT into `__DATA` segment where appropriate

We were previously always emitting the GOT into `__DATA_CONST`, even for
target platforms where it should end up in `__DATA`.

I stumbled onto this while trying to use the `class-dump` tool -- with
the wrong segment names, it fails to locate the ObjC runtime info and
therefore fails to dump any classes.

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D112500