[all-commits] [llvm/llvm-project] 1c2e24: [clangd] IncludeCleaner: don't stop the traversal

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Tue Oct 26 07:11:20 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c2e249f938c50e1b331a1f7adc83c0a381f3897
      https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2021-10-26 (Tue, 26 Oct 2021)

  Changed paths:
    M clang-tools-extra/clangd/IncludeCleaner.cpp

  Log Message:
  -----------
  [clangd] IncludeCleaner: don't stop the traversal

I was under the impression that `return false;` in the
RecursiveASTVisitor stops the traversal for the subtree but it appears
that it stops the whole tree traversal, so this change introduces a bug
where `ReferencedLocationCrawler` will not collect any symbols past an
enum.

This is a follow-up on D112209.




More information about the All-commits mailing list