[all-commits] [llvm/llvm-project] 26c584: [lldb] [gdb-remote] Remove HardcodeARMRegisters() ...

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26c584f4f1a3359bcb31b357ec020e7b8038c10c
      https://github.com/llvm/llvm-project/commit/26c584f4f1a3359bcb31b357ec020e7b8038c10c
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-10-25 (Mon, 25 Oct 2021)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

  Log Message:
  -----------
  [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

HardcodeARMRegisters() is a hack that was supposed to be used "until
we can get an updated debugserver down on the devices".  Since it was
introduced back in 2012, there is a good chance that the debugserver
has been updated at least once since then.  Removing this code makes
transition to the new DynamicRegisterInfo API easier.

Differential Revision: https://reviews.llvm.org/D111491


  Commit: 1bd258fd4e2c94d35cdda07b4ca64a2de8d4a047
      https://github.com/llvm/llvm-project/commit/1bd258fd4e2c94d35cdda07b4ca64a2de8d4a047
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-10-25 (Mon, 25 Oct 2021)

  Changed paths:
    M lldb/include/lldb/Target/DynamicRegisterInfo.h
    M lldb/source/Target/DynamicRegisterInfo.cpp
    M lldb/unittests/Target/DynamicRegisterInfoTest.cpp

  Log Message:
  -----------
  [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected

Now that AddRegister() is no longer used, remove it.  While at it,
we can also make Finalize() protected as all supported API methods
call it internally.

Differential Revision: https://reviews.llvm.org/D111498


Compare: https://github.com/llvm/llvm-project/compare/1b348902ea86...1bd258fd4e2c