[all-commits] [llvm/llvm-project] 77fdc0: [lld-macho] Simplify lc-linker-option.ll and re-en...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77fdc0e56bf9463b432f1a2073ac506a8df9b652
      https://github.com/llvm/llvm-project/commit/77fdc0e56bf9463b432f1a2073ac506a8df9b652
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-10-21 (Thu, 21 Oct 2021)

  Changed paths:
    M lld/test/MachO/lc-linker-option.ll

  Log Message:
  -----------
  [lld-macho] Simplify lc-linker-option.ll and re-enable it on Windows

While attempting to simplify it, I discovered a concerning discrepancy
between our handling of LC_LINKER_OPTION vs ld64's. In particular, ld64
does not appear to check for `-all_load` nor `-ObjC` when processing
those options. Thus, if/when we fix this behavior, no duplicate symbol
error will be expected regardless of the use-after-free. As such, I've
removed the test logic that tries to induce the duplicate symbol error.
We can just rely on ASAN to do the verification.

In order to make the test run on Windows, I've removed the symlink
logic. Both ld64 and LLD handle this un-symlinked framework just fine.

I also capitalized the framework name, since that's the typical
convention.

Reviewed By: #lld-macho, oontvoo

Differential Revision: https://reviews.llvm.org/D112195