[all-commits] [llvm/llvm-project] 72117f: [runtimes] Properly handle the sysroot/triple/gcc-...

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Oct 21 07:06:35 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 72117f2ffeb6a096a808c34ec7ebee122c2d2e21
      https://github.com/llvm/llvm-project/commit/72117f2ffeb6a096a808c34ec7ebee122c2d2e21
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-10-21 (Thu, 21 Oct 2021)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxxabi/CMakeLists.txt
    M libunwind/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Properly handle the sysroot/triple/gcc-toolchain

In 395271a, I simplified how we handled the target triple for the
runtimes. However, in doing so, we stopped considering the default
in CMAKE_CXX_COMPILER_TARGET, so we'd use the LLVM_DEFAULT_TARGET_TRIPLE
(which is the host triple) even if CMAKE_CXX_COMPILER_TARGET was specified.
This commit fixes that problem and also refactors the code so that it's
easy to see what the default value is.

The fact that nobody seems to have been broken by this makes me think
that perhaps nobody is using CMAKE_CXX_COMPILER_TARGET to specify the
triple -- but it should still work.

Differential Revision: https://reviews.llvm.org/D111672




More information about the All-commits mailing list