[all-commits] [llvm/llvm-project] 5a3556: [lldb] Add omitted abstract formal parameters in D...

[Jaroslav Sevcik via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a3556aa5563fb89693935303463881df44094de
      https://github.com/llvm/llvm-project/commit/5a3556aa5563fb89693935303463881df44094de
  Author: Jaroslav Sevcik <jarin at chromium.org>
  Date:   2021-10-21 (Thu, 21 Oct 2021)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
    A lldb/test/API/functionalities/unused-inlined-parameters/Makefile
    A lldb/test/API/functionalities/unused-inlined-parameters/TestUnusedInlinedParameters.py
    A lldb/test/API/functionalities/unused-inlined-parameters/main.c
    A lldb/test/Shell/SymbolFile/DWARF/x86/Inputs/unused-inlined-params.s
    A lldb/test/Shell/SymbolFile/DWARF/x86/unused-inlined-params.test

  Log Message:
  -----------
  [lldb] Add omitted abstract formal parameters in DWARF symbol files

This patch fixes a problem introduced by clang change
https://reviews.llvm.org/D95617 and described by
https://bugs.llvm.org/show_bug.cgi?id=50076#c6, where inlined functions
omit unused parameters both in the stack trace and in `frame var`
command. With this patch, the parameters are listed correctly in the
stack trace and in `frame var` command.

Specifically, we parse formal parameters from the abstract version of
inlined functions and use those formal parameters if they are missing
from the concrete version.

Differential Revision: https://reviews.llvm.org/D110571