[all-commits] [llvm/llvm-project] 320f65: [LLDB][NFC] Remove parameter names from forward de...

[Shafik Yaghmour via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 320f65ee65f40fadbd2016036e538e28ae28614c
      https://github.com/llvm/llvm-project/commit/320f65ee65f40fadbd2016036e538e28ae28614c
  Author: Shafik Yaghmour <syaghmour at apple.com>
  Date:   2021-10-19 (Tue, 19 Oct 2021)

  Changed paths:
    M lldb/examples/darwin/heap_find/heap.py

  Log Message:
  -----------
  [LLDB][NFC] Remove parameter names from forward declarations from hand written expressions used in heap.py part 2

heap.py has a lot of large hand written expressions and each name in the
expression will be looked up by clang during expression parsing. For
function parameters this will be in Sema::ActOnParamDeclarator(...) in order to
catch redeclarations of parameters. The names are not needed and we have seen
some rare cases where since we don't have symbols we end up in
SymbolContext::FindBestGlobalDataSymbol(...) which may conflict with other global
symbols.

There may be a way to make this lookup smarter to avoid these cases but it is
not clear how well tested this path is and how much work it would be to fix it.
So we will go with this fix while we investigate more.

This is a second try at getting all the cases we care about.

Ref: rdar://78265641