[all-commits] [llvm/llvm-project] 1053e0: [RISCV] Use a lambda to avoid having the Support l...

Craig Topper via All-commits all-commits at lists.llvm.org
Mon Oct 18 13:44:05 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1053e0b27ce135ce2da63af01aa986b9425386ee
      https://github.com/llvm/llvm-project/commit/1053e0b27ce135ce2da63af01aa986b9425386ee
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-10-18 (Mon, 18 Oct 2021)

  Changed paths:
    M clang/lib/Driver/ToolChains/Arch/RISCV.cpp
    M llvm/include/llvm/Support/RISCVISAInfo.h
    M llvm/lib/Support/RISCVISAInfo.cpp

  Log Message:
  -----------
  [RISCV] Use a lambda to avoid having the Support library depend on Option library.

RISCVISAInfo::toFeatures needs to allocate strings using
ArgList::MakeArgString, but toFeatures lives in Support and
MakeArgString lives in Option.

toFeature only has one caller, so the simple fix is to have that
caller pass a lamdba that wraps MakeArgString to break the
dependency.

Differential Revision: https://reviews.llvm.org/D112032




More information about the All-commits mailing list