[all-commits] [llvm/llvm-project] d8bc7e: [lldb] [lldb-server] Refactor ConnectToRemote()

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d8bc7e40ce1cdd8c1a3fac7937ce1ea85c262728
      https://github.com/llvm/llvm-project/commit/d8bc7e40ce1cdd8c1a3fac7937ce1ea85c262728
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-10-18 (Mon, 18 Oct 2021)

  Changed paths:
    M lldb/tools/lldb-server/lldb-gdbserver.cpp

  Log Message:
  -----------
  [lldb] [lldb-server] Refactor ConnectToRemote()

Refactor ConnectToRemote() to improve readability and make future
changes easier:

1. Replace static buffers with std::string.
2. When handling errors, prefer reporting the actual error over dumb
   'connection status is not success'.
3. Move host/port parsing directly into reverse_connection condition
   that is its only user, and simplify it to make its purpose (verifying
   that a valid port is provided) clear.
4. Use llvm::errs() and llvm::outs() instead of fprintf().

Differential Revision: https://reviews.llvm.org/D11196