[all-commits] [llvm/llvm-project] 239b4d: [lldb] [Utility] Remove Status::WasInterrupted() a...

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 239b4d62b6c07f27b1763a090f82c9f92ce06b8c
      https://github.com/llvm/llvm-project/commit/239b4d62b6c07f27b1763a090f82c9f92ce06b8c
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-10-18 (Mon, 18 Oct 2021)

  Changed paths:
    M lldb/include/lldb/Utility/Status.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Utility/Status.cpp

  Log Message:
  -----------
  [lldb] [Utility] Remove Status::WasInterrupted() along with its only use

Remove Status::WasInterrupted() that checks whether the underlying error
code matches EINTR.  ProcessGDBRemote::ConnectToDebugserver() is its
only call site, and it does not seem correct there.  After all, EINTR
is precisely when we want to retry, not stop retrying.  Furthermore,
it should not really matter since we should be catching EINTR
immediately via llvm::sys::RetryAfterSignal() but that's another story.

Differential Revision: https://reviews.llvm.org/D111908