[all-commits] [llvm/llvm-project] b5ff51: [lldb][NFC] Early-exit in DWARFASTParserClang::Par...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Sat Oct 9 05:41:10 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b5ff51104810d09071a5e6ac4c33a0c070f996ca
      https://github.com/llvm/llvm-project/commit/b5ff51104810d09071a5e6ac4c33a0c070f996ca
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-10-09 (Sat, 09 Oct 2021)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

  Log Message:
  -----------
  [lldb][NFC] Early-exit in DWARFASTParserClang::ParseSingleMember

ParseSingleMember has two large ifs around the back of it's body:
`if (!is_artificial)` and `if (member_type)`. This patch just converts those
to early-exits. The patch is NFC. It even retains the curious fact that
Objective-C properties that fail to parse are silently ignored, but now there
is at least a FIXME that points this out.




More information about the All-commits mailing list