[all-commits] [llvm/llvm-project] 048168: [CFE][Codegen][In-progress] Remove CodeGenFunction...

Mahesha S via All-commits all-commits at lists.llvm.org
Fri Oct 8 20:54:27 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04816829968cf8aad0c71e8dc27a4a1e88c493a8
      https://github.com/llvm/llvm-project/commit/04816829968cf8aad0c71e8dc27a4a1e88c493a8
  Author: hsmahesha <mahesha.comp at gmail.com>
  Date:   2021-10-09 (Sat, 09 Oct 2021)

  Changed paths:
    M clang/lib/CodeGen/CodeGenFunction.cpp

  Log Message:
  -----------
  [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

CodeGenFunction::InitTempAlloca() inits the static alloca within the
entry block which may *not* necessarily be correct always.

For example, the current instruction insertion point (pointed by the
instruction builder) could be a program point which is hit multiple
times during the program execution, and it is expected that the static
alloca is initialized every time the program point is hit.

Hence remove CodeGenFunction::InitTempAlloca(), and initialize the
static alloca where the instruction insertion point is at the moment.

This patch, as a starting attempt, removes the calls to
CodeGenFunction::InitTempAlloca() which do not have any side effect on
the lit tests.

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D111293




More information about the All-commits mailing list