[all-commits] [llvm/llvm-project] 57c56c: X86Vector: relax checks in rsqrt's integration test

Emilio Cota via All-commits all-commits at lists.llvm.org
Fri Oct 8 13:59:38 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57c56cf20cfa017b89bdabfc2bfd46384a25fdc7
      https://github.com/llvm/llvm-project/commit/57c56cf20cfa017b89bdabfc2bfd46384a25fdc7
  Author: Emilio Cota <ecg at google.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-rsqrt.mlir

  Log Message:
  -----------
  X86Vector: relax checks in rsqrt's integration test

Instead of hard-coding results for both Intel and AMD, let's relax
the checks to simplify the test while supporting both implementations.
Note that:
- If a new hardware implementation comes up in the future, it is likely
  to pass the relaxed tests, i.e. no future maintenance burden for us.
- If something terribly wrong happens (e.g. instead of rsqrt we
  execute 1/sqrt), the tests will probably catch it, since the relaxed
  tests expect low precision (e.g. rsqrt(1) != 1.0).

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D111461




More information about the All-commits mailing list