[all-commits] [llvm/llvm-project] 8ed2e8: [mlir][linalg] Retire Linalg ConvOp.

Tobias Gysi via All-commits all-commits at lists.llvm.org
Thu Oct 7 23:57:39 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ed2e8e04ff42eb4d8009999ae1fd341a30bf6c0
      https://github.com/llvm/llvm-project/commit/8ed2e8e04ff42eb4d8009999ae1fd341a30bf6c0
  Author: Tobias Gysi <gysit at google.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.h
    M mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
    M mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
    M mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Generalization.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Loops.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
    M mlir/test/Dialect/Linalg/affine.mlir
    M mlir/test/Dialect/Linalg/fusion-pattern.mlir
    M mlir/test/Dialect/Linalg/fusion.mlir
    M mlir/test/Dialect/Linalg/generalize-named-ops.mlir
    M mlir/test/Dialect/Linalg/loops.mlir
    M mlir/test/Dialect/Linalg/roundtrip.mlir
    R mlir/test/Dialect/Linalg/tile-conv-padding.mlir
    M mlir/test/Dialect/Linalg/tile-conv.mlir
    R mlir/test/Dialect/Linalg/tile-simple-conv.mlir
    M mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp

  Log Message:
  -----------
  [mlir][linalg] Retire Linalg ConvOp.

The convolution op is one of the remaining hard coded Linalg operations that have no region attached. It got obsolete due to the OpDSL convolution operations. Removing it allows us to delete specialized code and tests that are not needed for the OpDSL counterparts that rely on the standard code paths.

Test needed due to specialized implementations are removed. Tiling and fusion tests are replaced by variants using linalg.conv_2d.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D111233




More information about the All-commits mailing list