[all-commits] [llvm/llvm-project] 81b5da: [CostModel][TTI] Replace BAD_ICMP_PREDICATE with I...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Wed Oct 6 11:11:49 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 81b5da8c97463839d5631628f9687e26dcca467f
      https://github.com/llvm/llvm-project/commit/81b5da8c97463839d5631628f9687e26dcca467f
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-10-06 (Wed, 06 Oct 2021)

  Changed paths:
    M llvm/include/llvm/CodeGen/BasicTTIImpl.h
    M llvm/test/Analysis/CostModel/X86/arith-overflow.ll
    M llvm/test/Analysis/CostModel/X86/arith-usat.ll

  Log Message:
  -----------
  [CostModel][TTI] Replace BAD_ICMP_PREDICATE with ICMP_ULT/UGT for generic uadd/usubo cost expansion

Match the predicates used in TargetLowering::expandUADDSUBO


  Commit: 7bd097fd1e4a76060a19f1e28b0e3a6b3e035132
      https://github.com/llvm/llvm-project/commit/7bd097fd1e4a76060a19f1e28b0e3a6b3e035132
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-10-06 (Wed, 06 Oct 2021)

  Changed paths:
    M llvm/include/llvm/CodeGen/BasicTTIImpl.h
    M llvm/test/Analysis/CostModel/ARM/arith-overflow.ll
    M llvm/test/Analysis/CostModel/X86/arith-overflow.ll
    M llvm/test/Analysis/CostModel/X86/intrinsic-cost-kinds.ll

  Log Message:
  -----------
  [CostModel][TTI] Fix ops used for generic smulo/umulo cost expansion

Fix copy+pasta that was checking for smul_fix instead of smul_with_overflow to detected signed values.

The LShr is performed on the extended type as we use it to truncate+extract the upper/hi bits of the extended multiply.

More closely matches the default expansion from TargetLowering::expandMULO


  Commit: 2ced9a42be8aba4533225fdb8ed02fe6f50060b6
      https://github.com/llvm/llvm-project/commit/2ced9a42be8aba4533225fdb8ed02fe6f50060b6
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-10-06 (Wed, 06 Oct 2021)

  Changed paths:
    M llvm/include/llvm/CodeGen/BasicTTIImpl.h
    M llvm/test/Analysis/CostModel/X86/arith-overflow.ll
    M llvm/test/Analysis/CostModel/X86/intrinsic-cost-kinds.ll

  Log Message:
  -----------
  [CostModel][TTI] Replace BAD_ICMP_PREDICATE with ICMP_NE for generic smulo/umulo cost expansion

Match the predicate used in TargetLowering::expandMULO to detect overflow


Compare: https://github.com/llvm/llvm-project/compare/77d5ccdc6f46...2ced9a42be8a


More information about the All-commits mailing list