[all-commits] [llvm/llvm-project] 8cf531: [libc++][test] Use = delete over DELETE_FUNCTION. ...

Joseph Loser via All-commits all-commits at lists.llvm.org
Tue Oct 5 11:09:40 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8cf5319affc2441c2901908140c14f7153078199
      https://github.com/llvm/llvm-project/commit/8cf5319affc2441c2901908140c14f7153078199
  Author: Joe Loser <joeloser93 at gmail.com>
  Date:   2021-10-05 (Tue, 05 Oct 2021)

  Changed paths:
    M libcxx/test/libcxx/iterators/contiguous_iterators.pass.cpp
    M libcxx/test/std/utilities/memory/storage.iterator/raw_storage_iterator.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_shared.pass.cpp
    M libcxx/test/support/test_allocator.h
    M libcxx/test/support/test_iterators.h

  Log Message:
  -----------
  [libc++][test] Use = delete over DELETE_FUNCTION. NFC.

Some tests repeat the definition of `DELETE_FUNCTION` macro locally.
However, it's not even requred to guard against in the C++03 case since
Clang supports `= delete;` in C++03 mode. A warning is issued but
`libc++` tests run with `-Wno-c++11-extensions`, so this isn't an issue.
Since we don't support other compilers in C++03 mode, `= delete;` is
always available for use. As such, inline all calls of `DELETE_FUNCTION`
to use `= delete;`.

Reviewed By: ldionne, #libc

Differential Revision: https://reviews.llvm.org/D111148




More information about the All-commits mailing list