[all-commits] [llvm/llvm-project] 02895e: [llvm-cxxfilt][NFC] Fix test for running in Window...

Orlando Cazalet-Hyams via All-commits all-commits at lists.llvm.org
Tue Oct 5 04:10:34 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 02895eede1a9a650e84d72afea2cd6ecf35ac1e7
      https://github.com/llvm/llvm-project/commit/02895eede1a9a650e84d72afea2cd6ecf35ac1e7
  Author: gbhyamso <orlando.hyams at sony.com>
  Date:   2021-10-05 (Tue, 05 Oct 2021)

  Changed paths:
    M llvm/test/tools/llvm-cxxfilt/delimiters.test

  Log Message:
  -----------
  [llvm-cxxfilt][NFC] Fix test for running in Windows cmd

The test llvm\test\tools\llvm-cxxfilt\delimiters.test started failling when run
from cmd.exe on Windows after D110986 which added a unicode character (⦙) to it.
Piping the unicode character in cmd.exe causes it to be converted to a '?'.
That causes the test to fail because the llvm-cxxfilt output becomes Foo?Bar
rather than the expected Foo⦙Bar.

Redirect the echo output to and from a temporary file to get around this
problem.

It's not entirely clear what the root cause is, but two separate downstream
builders are tripping up on this, so we are landing the work around for the
time being.

Differential Revision: https://reviews.llvm.org/D111072




More information about the All-commits mailing list