[all-commits] [llvm/llvm-project] a785e5: [runtimes] Set a default value for LLVM_LIT_ARGS

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a785e5c3958eda8aafd6a6da2b23be2b92d3b165
      https://github.com/llvm/llvm-project/commit/a785e5c3958eda8aafd6a6da2b23be2b92d3b165
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-10-05 (Tue, 05 Oct 2021)

  Changed paths:
    M runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Set a default value for LLVM_LIT_ARGS

This matches the value used in
libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake.

Differential Revision: https://reviews.llvm.org/D110987


  Commit: a8d15a926689c126c4d316788786e0160cfc1d5d
      https://github.com/llvm/llvm-project/commit/a8d15a926689c126c4d316788786e0160cfc1d5d
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-10-05 (Tue, 05 Oct 2021)

  Changed paths:
    M libcxx/include/__config

  Log Message:
  -----------
  [libcxx] Don't autodetect pthreads on MinGW

e9ee517930f76a972fcda00d9dd0466db80d60f7 added support for using
winpthreads on Windows, enabled if `__WINPTHREADS_VERSION` was
defined (i.e. if winpthreads headers have been included before
including libcxx `__config`). This was fragile (libcxx changed
behaviour depending on what headers had been included externally
before), and was changed in a1bc823a59d5b6f310bdf6c7c7b62ec71b87d1aa
to use pthreads on Windows whenever the pthread.h header was
available.

This is also fragile; pthread.h might be unavailable while building
libcxx but installed later, and available when users include the
libcxx headers.

In practice, in every modern setup for building libcxx for Windows
I've seen, users end up manually configuring it with
`LIBCXX_HAS_WIN32_THREAD_API=ON`, as the users may have winpthreads
installed (for other libraries/projects to use) while wanting to
build libcxx with the default win32 threading.

Don't automatically pick up pthreads on Windows even if the header
is available. Instead require the user to configure the libcxx
build with `LIBCXX_HAS_PTHREAD_API=ON` if that's desired.

Differential Revision: https://reviews.llvm.org/D110975


  Commit: 204d56394845a36136e1d27cf93f300fb6795788
      https://github.com/llvm/llvm-project/commit/204d56394845a36136e1d27cf93f300fb6795788
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-10-05 (Tue, 05 Oct 2021)

  Changed paths:
    M libcxx/test/std/language.support/support.runtime/ctime.pass.cpp
    M libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Move a missed test to ctime.timespec.compile.pass.cpp

This was missed in ec574f5da463d303a3771597c233e52d2429db67. TIME_UTC
is a define that goes along with timespec_get. The testcase that it is
moved to is only run for >= C++17, so the surrounding ifdef guard
can be dropped.

Differential Revision: https://reviews.llvm.org/D110988


Compare: https://github.com/llvm/llvm-project/compare/c2eff3d5b931...204d56394845