[all-commits] [llvm/llvm-project] e2b838: [DebugInfo][InstrRef] Accept landingpad block argu...

Jeremy Morse via All-commits all-commits at lists.llvm.org
Mon Oct 4 15:10:47 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e2b838dd913200702f2eee29100a788c0573bc50
      https://github.com/llvm/llvm-project/commit/e2b838dd913200702f2eee29100a788c0573bc50
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2021-10-04 (Mon, 04 Oct 2021)

  Changed paths:
    M llvm/lib/CodeGen/MachineFunction.cpp
    A llvm/test/DebugInfo/X86/instr-ref-eh-landing-pad.ll

  Log Message:
  -----------
  [DebugInfo][InstrRef] Accept landingpad block arguments

This patch makes instruction-referencing accepts an additional scenario
where values can be read from physical registers at the start of blocks. As
far as I was aware, this only happened:
 * With arguments in the entry block,
 * With constant physical registers,

To which this patch adds a third case:
 * With exception-handling landing-pad blocks

In the attached test: the operand of the dbg.value traces back to the
"landingpad" instruction, which becomes some copies from physregs. Right
now, that's deemed unacceptable, and the assertion fires. The fix is to
just accept this scenario; this is a case where the value in question is
defined by a register and a position, not by an instruction that defines
it. Reading it with a DBG_PHI is the correct behaviour, there isn't a
non-copy instruction that we can refer to.

Differential Revision: https://reviews.llvm.org/D109005




More information about the All-commits mailing list