[all-commits] [llvm/llvm-project] 9892d1: [libc++][libc++abi] Add tests for vendor-specific ...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9892d1644f62cf8f5133ee0d2ebafb56f6500cc1
      https://github.com/llvm/llvm-project/commit/9892d1644f62cf8f5133ee0d2ebafb56f6500cc1
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-09-29 (Wed, 29 Sep 2021)

  Changed paths:
    M libcxx/cmake/caches/Apple.cmake
    M libcxx/test/configs/legacy.cfg.in
    M libcxx/test/configs/libcxx-trunk-shared.cfg.in
    M libcxx/test/configs/libcxx-trunk-static.cfg.in
    A libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
    M libcxx/test/std/strings/c.strings/cuchar.pass.cpp
    M libcxx/test/std/utilities/charconv/charconv.from.chars/integral.bool.fail.cpp
    M libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
    M libcxx/test/std/utilities/charconv/charconv.from.chars/integral.roundtrip.pass.cpp
    M libcxx/test/std/utilities/charconv/charconv.to.chars/integral.bool.fail.cpp
    M libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bm/default.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bm/hash.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bm/hash.pred.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bm/pred.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bmh/default.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bmh/hash.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bmh/hash.pred.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.search/func.search.bmh/pred.pass.cpp
    M libcxx/utils/libcxx/test/config.py
    M libcxx/utils/libcxx/test/params.py
    M libcxxabi/test/lit.site.cfg.in
    A libcxxabi/test/vendor/apple/system-install-properties.sh.cpp

  Log Message:
  -----------
  [libc++][libc++abi] Add tests for vendor-specific properties

Vendors take libc++ and ship it in various ways. Some vendors might
ship it differently from what upstream LLVM does, i.e. the install
location might be different, some ABI properties might differ, etc.

In the past few years, I've come across several instances where
having a place to test some of these properties would have been
incredibly useful. I also just got bitten by the lack of tests
of that kind, so I'm adding some now.

The tests added by this commit for Apple platforms have numerous
TODOs that capture discrepancies between the upstream LLVM CMake
and the slightly-modified build we perform internally to produce
Apple's system libc++. In the future, the goal would be to upstream
all those differences so that it's possible to build a faithful
Apple system libc++ with the upstream LLVM sources only.

But this isn't only useful for Apple - this lays out the path for
any vendor being able to add their own checks (either upstream or
downstream) to libc++.

Differential Revision: https://reviews.llvm.org/D110736