[all-commits] [llvm/llvm-project] 204d30: [mlir][Python] Fix lifetime of ExecutionEngine run...

Sean Silva via All-commits all-commits at lists.llvm.org
Tue Sep 28 15:32:35 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 204d301bb1921431a853c0bfba32007c018df1d5
      https://github.com/llvm/llvm-project/commit/204d301bb1921431a853c0bfba32007c018df1d5
  Author: Sean Silva <silvasean at google.com>
  Date:   2021-09-28 (Tue, 28 Sep 2021)

  Changed paths:
    M mlir/lib/Bindings/Python/ExecutionEngineModule.cpp
    M mlir/python/mlir/execution_engine.py

  Log Message:
  -----------
  [mlir][Python] Fix lifetime of ExecutionEngine runtime functions.

We weren't retaining the ctypes closures that the ExecutionEngine was
calling back into, leading to mysterious errors.

Open to feedback about how to test this. And an extra pair of eyes to
make sure I caught all the places that need to be aware of this.

Differential Revision: https://reviews.llvm.org/D110661




More information about the All-commits mailing list