[all-commits] [llvm/llvm-project] b2a2c3: Fix bug in readability-uppercase-literal-suffix

Carlos Galvez via All-commits all-commits at lists.llvm.org
Mon Sep 27 11:04:11 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b2a2c38349a18b89b04d342632d5ea02f86dfdd6
      https://github.com/llvm/llvm-project/commit/b2a2c38349a18b89b04d342632d5ea02f86dfdd6
  Author: Carlos Galvez <carlosgalvezp at gmail.com>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp
    M clang-tools-extra/test/clang-tidy/checkers/readability-uppercase-literal-suffix-integer.cpp

  Log Message:
  -----------
  Fix bug in readability-uppercase-literal-suffix

Fixes https://bugs.llvm.org/show_bug.cgi?id=51790. The check triggers
incorrectly with non-type template parameters.

A bisect determined that the bug was introduced here:
https://github.com/llvm/llvm-project/commit/ea2225a10be986d226e041d20d36dff17e78daed

Unfortunately that patch can no longer be reverted on top of the main
branch, so add a fix instead. Add a unit test to avoid regression in
the future.




More information about the All-commits mailing list