[all-commits] [llvm/llvm-project] 531206: [mlir:OpAsm] Factor out the common bits of (Op/Dia...

River Riddle via All-commits all-commits at lists.llvm.org
Fri Sep 24 13:16:32 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 531206310a27477f088f672f5e6fd688d77d9292
      https://github.com/llvm/llvm-project/commit/531206310a27477f088f672f5e6fd688d77d9292
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-09-24 (Fri, 24 Sep 2021)

  Changed paths:
    M mlir/include/mlir/IR/DialectImplementation.h
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/IR/Dialect.cpp
    M mlir/lib/IR/Operation.cpp
    A mlir/lib/Parser/AsmParserImpl.h
    M mlir/lib/Parser/DialectSymbolParser.cpp
    M mlir/lib/Parser/Parser.cpp

  Log Message:
  -----------
  [mlir:OpAsm] Factor out the common bits of (Op/Dialect)Asm(Parser/Printer)

This has a few benefits:
* It allows for defining parsers/printer code blocks that
  can be shared between operations and attribute/types.
* It removes the weird duplication of generic parser/printer hooks,
  which means that newly added hooks only require touching one class.

Differential Revision: https://reviews.llvm.org/D110375




More information about the All-commits mailing list