[all-commits] [llvm/llvm-project] 8229cb: [LiveIntervals] Fix repairOldRegInRange for simple...

Jay Foad via All-commits all-commits at lists.llvm.org
Thu Sep 23 09:16:39 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8229cb74125322ff337cfe316ab35c6ebf412bde
      https://github.com/llvm/llvm-project/commit/8229cb74125322ff337cfe316ab35c6ebf412bde
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2021-09-23 (Thu, 23 Sep 2021)

  Changed paths:
    M llvm/lib/CodeGen/LiveIntervals.cpp
    M llvm/test/CodeGen/AMDGPU/extract-load-i1.ll
    A llvm/test/CodeGen/AMDGPU/twoaddr-regsequence.mir
    M llvm/test/CodeGen/ARM/signext-inreg.ll
    M llvm/test/CodeGen/X86/mul-shift-reassoc.ll

  Log Message:
  -----------
  [LiveIntervals] Fix repairOldRegInRange for simple def cases

The fix applied in D23303 "LiveIntervalAnalysis: fix a crash in repairOldRegInRange"
was over-zealous. It would bail out when the end of the range to be
repaired was in the middle of the first segment of the live range of
Reg, which was always the case when the range contained a single def of
Reg.

This patch fixes it as suggested by Matthias Braun in post-commit review
on the original patch, and tests it by adding -early-live-intervals to
a selection of existing lit tests that now pass.

(Note that D23303 was originally applied to fix a crash in
SILoadStoreOptimizer, but that is now moot since D23814 updated
SILoadStoreOptimizer to run before scheduling so it no longer has to
update live intervals.)

Differential Revision: https://reviews.llvm.org/D110238




More information about the All-commits mailing list