[all-commits] [llvm/llvm-project] 85a586: [BasicBlockUtils] Fixup of an assumed typo in Merg...

Björn Pettersson via All-commits all-commits at lists.llvm.org
Thu Sep 23 04:04:14 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 85a586501bcc5b556d34a566b9d256d56d6fc5ba
      https://github.com/llvm/llvm-project/commit/85a586501bcc5b556d34a566b9d256d56d6fc5ba
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2021-09-23 (Thu, 23 Sep 2021)

  Changed paths:
    M llvm/lib/Transforms/Utils/BasicBlockUtils.cpp

  Log Message:
  -----------
  [BasicBlockUtils] Fixup of an assumed typo in MergeBlockIntoPredecessor

The NFC commit e5692a564a73ef63b7b changed the logic for
DomTreeUpdates to use the range [succ_begin, succ_begin) when
looking for SuccsOfPredBB rather than using [succ_begin, succ_end).

As the commit was NFC this is identified as a typo (it has been
discussed briefly in phabricator).

The typo was found when inspecting the code, so I've got no idea if
changing back to the old range has any significant impact (such as
solving any PR:s or causing some new problems). But at least this
restores the code to the originally indented behavior.




More information about the All-commits mailing list