[all-commits] [llvm/llvm-project] bc4a23: [libc++][test] Fix iterator assertion in span.cons...

Joseph Loser via All-commits all-commits at lists.llvm.org
Tue Sep 21 19:47:09 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc4a23811b021f4e5369162ed84f88a0240a81e2
      https://github.com/llvm/llvm-project/commit/bc4a23811b021f4e5369162ed84f88a0240a81e2
  Author: Joe Loser <joeloser93 at gmail.com>
  Date:   2021-09-21 (Tue, 21 Sep 2021)

  Changed paths:
    M libcxx/test/std/containers/views/span.cons/deduct.pass.cpp

  Log Message:
  -----------
  [libc++][test] Fix iterator assertion in span.cons/deduct.pass.cpp

Two tests in span.cons/deduct.pass.cpp accidentally check whether the
iterator range from member begin and member end are equivalent to the
ones from free begin and free end. This is obviously true and not
intended. Correct the intent by comparing the size/data from the span
with the source input.

While in the neighborhood, add test for const int arr[N], remove extraneous
type aliases, unused <type_traits> header, and the
disable_missing_braces_warning.h include.

Reviewed By: Quuxplusone, ldionne, #libc

Differential Revision: https://reviews.llvm.org/D109668




More information about the All-commits mailing list