[all-commits] [llvm/llvm-project] c9af0e: [libc++] counting_semaphore should not be default-...

[Quuxplusone via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c9af0e61fa85842ce280ddab8ab491de38a7ae5b
      https://github.com/llvm/llvm-project/commit/c9af0e61fa85842ce280ddab8ab491de38a7ae5b
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-09-21 (Tue, 21 Sep 2021)

  Changed paths:
    M libcxx/include/semaphore
    M libcxx/test/std/thread/thread.semaphore/binary.pass.cpp
    A libcxx/test/std/thread/thread.semaphore/ctor.compile.pass.cpp
    M libcxx/test/std/thread/thread.semaphore/max.pass.cpp

  Log Message:
  -----------
  [libc++] counting_semaphore should not be default-constructible.

Neither the current C++2b draft, nor any revision of [p1135],
nor libstdc++, claims that `counting_semaphore` should be
default-constructible. I think this was just a copy-paste issue
somehow.

Also, `explicit` was missing from the constructor.

Also, `constexpr` remains missing; but that's probably more of a
technical limitation, since apparently there are some platforms
where we don't (can't??) use the atomic implementation and
have to rely on pthreads, which obviously isn't constexpr.

Differential Revision: https://reviews.llvm.org/D110042