[all-commits] [llvm/llvm-project] 791b6e: [lldb] Speculative fix to TestGuiExpandThreadsTree

Pavel Labath via All-commits all-commits at lists.llvm.org
Tue Sep 21 01:03:23 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 791b6ebc86680168d634103b67a92a354c075cc4
      https://github.com/llvm/llvm-project/commit/791b6ebc86680168d634103b67a92a354c075cc4
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2021-09-21 (Tue, 21 Sep 2021)

  Changed paths:
    M lldb/test/API/commands/gui/expand-threads-tree/Makefile
    M lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
    R lldb/test/API/commands/gui/expand-threads-tree/main.c
    A lldb/test/API/commands/gui/expand-threads-tree/main.cpp

  Log Message:
  -----------
  [lldb] Speculative fix to TestGuiExpandThreadsTree

This test relies on being able to unwind from an arbitrary place inside
libc. While I am not sure this is the cause of the observed flakyness,
it is known that we are not able to unwind correctly from some places in
(linux) libc.

This patch adds additional synchronization to ensure that the inferior
is in the main function (instead of pthread guts) when lldb tries to
unwind it. At the very least, it should make the test runs more
predictable/repeatable.




More information about the All-commits mailing list