[all-commits] [llvm/llvm-project] 129cf3: [DSE][NFC] Rename Later->Killing, Earlier->Dead

ebrevnov via All-commits all-commits at lists.llvm.org
Mon Sep 20 23:44:26 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 129cf336041f0ed7454c0f6866401d2847dd3967
      https://github.com/llvm/llvm-project/commit/129cf336041f0ed7454c0f6866401d2847dd3967
  Author: Evgeniy Brevnov <ybrevnov at azul.com>
  Date:   2021-09-21 (Tue, 21 Sep 2021)

  Changed paths:
    M llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp

  Log Message:
  -----------
  [DSE][NFC] Rename Later->Killing, Earlier->Dead

First (and biggest) change is to use "Killing/Dead" in place of "Later/Earlier" base for names in DSE. For example, [Maybe]DeadLoc - is a location killed by KillingI instruction. I believe such names are more descriptive and easy to understand than current ones.

Second, there are inconsistencies in naming where different names are used for the same thing. Fixed that too.

Third, reordered parameters of isPartialOverwrite, tryToMergePartialOverlappingStores, isOverwrite to make them consistent between each other. This greatly reduces potential mistakes.

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D106947




More information about the All-commits mailing list