[all-commits] [llvm/llvm-project] d5db71: [libc++] [P0919] Some belated review on D87171.

[Quuxplusone via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d5db71d19f11d7c31257066aea6bd41ef04f28b7
      https://github.com/llvm/llvm-project/commit/d5db71d19f11d7c31257066aea6bd41ef04f28b7
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2021-09-20 (Mon, 20 Sep 2021)

  Changed paths:
    M libcxx/include/map
    M libcxx/include/unordered_map
    M libcxx/include/unordered_set
    M libcxx/test/std/containers/unord/unord.map/contains.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.map/count.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.map/equal_range.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.map/equal_range_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.map/equal_range_non_const.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.map/find.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.map/find_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.map/find_non_const.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/contains.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/count.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.multimap/equal_range.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multimap/equal_range_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multimap/equal_range_non_const.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.multimap/find.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multimap/find_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multimap/find_non_const.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.multiset/contains.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.multiset/count.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.multiset/equal_range.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multiset/equal_range_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multiset/equal_range_non_const.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.multiset/find.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multiset/find_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.multiset/find_non_const.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.set/contains.transparent.pass.cpp
    M libcxx/test/std/containers/unord/unord.set/count.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.set/equal_range.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.set/equal_range_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.set/equal_range_non_const.transparent.pass.cpp
    A libcxx/test/std/containers/unord/unord.set/find.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.set/find_const.transparent.pass.cpp
    R libcxx/test/std/containers/unord/unord.set/find_non_const.transparent.pass.cpp
    M libcxx/test/support/is_transparent.h
    M libcxx/test/support/test_transparent_unordered.h

  Log Message:
  -----------
  [libc++] [P0919] Some belated review on D87171.

- Simplify the structure of the new tests.
- Test const containers as well as non-const containers,
    since it's easy to do so.
- Remove redundant enable-iffing of helper structs' member functions.
    (They're not instantiated unless they're called, and who would call them?)
- Fix indentation and use more consistent SFINAE method in <unordered_map>.
- Add _LIBCPP_INLINE_VISIBILITY on some swap functions.

Differential Revision: https://reviews.llvm.org/D109011