[all-commits] [llvm/llvm-project] 63838d: [examples] Fix SectionMemoryManager deconstruction...

lhames via All-commits all-commits at lists.llvm.org
Thu Sep 16 23:58:38 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 63838d88145feaeb839efff8f40ab1e98597e423
      https://github.com/llvm/llvm-project/commit/63838d88145feaeb839efff8f40ab1e98597e423
  Author: Lang Hames <lhames at gmail.com>
  Date:   2021-09-17 (Fri, 17 Sep 2021)

  Changed paths:
    M llvm/lib/ExecutionEngine/SectionMemoryManager.cpp

  Log Message:
  -----------
  [examples] Fix SectionMemoryManager deconstruction error with MSVC.

This commit fixes an order-of-initialization issue: If the default mmapper
object is destroyed while some global SectionMemoryManager is still using it
then calls to the mapper from ~SectionMemoryManager will fail. This issue was
causing failures when running the LLVM Kaleidoscope examples on windows.

Switching to a ManagedStatic solves the initialization order issue.

Patch by Justice Adams. Thanks Justice!

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D107087




More information about the All-commits mailing list