[all-commits] [llvm/llvm-project] 47373f: [compiler-rt][test] Add int128 requirement to Test...

PiJoules via All-commits all-commits at lists.llvm.org
Thu Sep 16 17:05:19 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 47373f94a431d7fcc78c760ca6ca321f3742b746
      https://github.com/llvm/llvm-project/commit/47373f94a431d7fcc78c760ca6ca321f3742b746
  Author: Leonard Chan <leonardchan at google.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M compiler-rt/test/ubsan/TestCases/Misc/Linux/static-link.cpp

  Log Message:
  -----------
  [compiler-rt][test] Add int128 requirement to TestCases/Misc/Linux/static-link.cpp

We hit some undefined symbol errors to 128-bit floating point functions when linking this test.

ld.lld: error: undefined symbol: __multf3
>>> referenced by strtof128_l.o:(round_and_return) in archive /usr/lib/x86_64-linux-gnu/libc.a
>>> referenced by strtof128_l.o:(round_and_return) in archive /usr/lib/x86_64-linux-gnu/libc.a
>>> referenced by strtof128_l.o:(round_and_return) in archive /usr/lib/x86_64-linux-gnu/libc.a
>>> referenced 4 more times
>>> did you mean: __muldf3
>>> defined in: /usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-1-master-fuchsia-toolchain/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.builtins.a

Host libc expects these to be defined, and compiler-rt will only define these
for certain platforms (see definition for CRT_LDBL_128BIT). Since we likely
can't do anything about the host libc, we can at least restrict the test to
check that these functions are supported.

Differential Revision: https://reviews.llvm.org/D109709




More information about the All-commits mailing list