[all-commits] [llvm/llvm-project] ceded4: Don't set executable file in ObjectFileMachO::Load...

Jason Molenda via All-commits all-commits at lists.llvm.org
Thu Sep 16 01:39:03 PDT 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ceded4153245322c45d28068860fb3d8d0a4884d
      https://github.com/llvm/llvm-project/commit/ceded4153245322c45d28068860fb3d8d0a4884d
  Author: Jason Molenda <jason at molenda.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

  Log Message:
  -----------
  Don't set executable file in ObjectFileMachO::LoadCoreFileImages

When the corefile reader is adding binaries from the "all image
infos" LC_NOTE in a Mach-O corefile, it would detect if the binary
being added was an executable binary and set it as the Target's
executable binary.  This has the side effect of clearing the Target's
image list, so if the executable was in the middle of the all image
infos, the initial images would be dropped.  There's no need to set
the executable binary in the Target for these corefile processes,
so instead of doing multiple passes over the list to find the
executable, I'm dropping that.




More information about the All-commits mailing list