[all-commits] [llvm/llvm-project] 662493: [lldb] [gdb-remote] Try using <architecture/> for ...

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 66249323d25f6db1dc76bd9fb3b9eebe436519a6
      https://github.com/llvm/llvm-project/commit/66249323d25f6db1dc76bd9fb3b9eebe436519a6
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBServerTargetXML.py
    A lldb/test/API/functionalities/gdb_remote_client/basic_eh_frame-i386.yaml

  Log Message:
  -----------
  [lldb] [gdb-remote] Try using <architecture/> for remote arch unconditionally

Try determining the process architecture from <architecture/> tag
unconditionally, rather than for very specific cases.  Generic gdbserver
implementations do not support LLDB-specific packets used to determine
the process architecture, therefore this fallback is necessary to
support architecture-specific behavior on these targets.  Rather than
maintaining a mapping of all known architectures, just try mapping
the GDB values into triplets, as that is going to work most of the time.

This change is confirmed to fix LLDB against gdbserver when debugging
i386 and aarch64 executables.

Differential Revision: https://reviews.llvm.org/D109272


  Commit: c208deb9008260d3effc00c98493434a65af4b8d
      https://github.com/llvm/llvm-project/commit/c208deb9008260d3effc00c98493434a65af4b8d
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBServerTargetXML.py

  Log Message:
  -----------
  [lldb] [ABI/AArch64] Recognize special regs by their xN names too

Recognize lr/sp/fp by their numeric register names in the ABI plugin.
This is necessary to mark them appropriately when interfacing with
gdbserver.

Differential Revision: https://reviews.llvm.org/D109691


Compare: https://github.com/llvm/llvm-project/compare/a4e437e3c959...c208deb90082